Borders serializer crashes

[MrMorag]

Namespace: MigraDoc.DocumentObjectModel
Class: Borders
Method: internal void Serialize(Serializer serializer, Borders? refBorders)

DiagonalDown is checked for null, but DiagonalUp is used then, which leads to a null ref exception:

internal void Serialize(Serializer serializer, Borders? refBorders)
{
...
if (!Values.DiagonalDown.IsValueNullOrEmpty())
{
Values.DiagonalUp!.Serialize(serializer, "DiagonalDown", null);
}
if (!Values.DiagonalUp.IsValueNullOrEmpty())
{
Values.DiagonalUp!.Serialize(serializer, "DiagonalUp", null);
}

[ThomasHoevel]

Do you have code that actually leads to a crash?
Just asking...
Yes, code looks wrong, but I guess it never gets executed.
Thanks for the feedback. Gonna fix it with the next release.

[MrMorag]

Yes, in our project it crashes exactly at this line if "DdlWriter.WriteToString(document)" is called for a preview.
It's a simple PDF with a table and borders. The creation of the PDF with the same data worked with 1.32 and the 1.5 versions

[MrMorag]

Meanwhile I figured out how to reproduce, add a table and set only:
table.Borders.DiagonalDown.Visible = false;

[ThomasHoevel]

Meanwhile I fixed it in our internal code. Thanks again for the feedback.
Setting DiagonalDown has no effect AFAIK - except for the crash in the Serializer.