Skip to content

v0.4.3 - fix green-button save on settings screen

Choose a tag to compare

View all tags
@empyfi empyfi released this 09 Jun 16:43
· 23 commits to main since this release
v0.4.3
48e3512

Summary

Bug-fix release. The settings screen introduced in v0.4.2 looked
correct on every skin but had a broken Save path: pressing the
green button did not close the screen, and the live controller
was not notified of the change. The values themselves were still
written to /etc/enigma2/settings (so a subsequent enigma2
restart picked them up), but from the user's point of view the
green button appeared to do nothing.

v0.4.3 fixes the override that swallowed the close path. No
other changes; layout, descriptions, group headers, and the 13
underlying toggles are identical to v0.4.2.

What was wrong

Components.ConfigList.ConfigListScreen.saveAll() returns an
empty tuple () on a normal successful save (and a
(QUIT_RESTART, ...) / (QUIT_REBOOT, ...) tuple when a
restart-marked item changed), not a boolean. The v0.4.2
keySave override read it as if not self.saveAll(): return,
short-circuited on the empty tuple, and never reached the close
path or the controller.on_config_changed() hook.

The fix runs the controller hook first and delegates the save +
close + restart-prompt logic to the parent Setup.keySave().
That picks up the standard restart confirmation flow for free,
even though no current setup.xml row needs it.

Install

wget https://github.com/empyfi/FBC-ChannelSpeedChange/releases/download/v0.4.3/enigma2-plugin-extensions-fbc-channelspeedchange_0.4.3_all.ipk -O /tmp/fbc-csc.ipk
opkg install --force-reinstall /tmp/fbc-csc.ipk
init 4 && init 3

Changelog

See CHANGELOG.md.

Assets 3
Loading