fix: harden security and improve performance across the codebase#27
Merged
johnny-emp merged 2 commits intomainfrom Feb 13, 2026
Merged
fix: harden security and improve performance across the codebase#27johnny-emp merged 2 commits intomainfrom
johnny-emp merged 2 commits intomainfrom
Conversation
e238c4f to
c72e266
Compare
Security fixes: - Fix SQL injection in scheduler list_tasks via parameterized queries - Fix SQL injection in DLQ replayer ByErrorType with strict input validation - Add SQL identifier validation in azoth-vector VectorSearch::new - Document unsafe extension loading risks in azoth-vector - Redact API credentials from IpfsProvider Debug output Performance improvements: - Use read-only transactions in benchmark read test - Add exponential backoff to LMDB read pool blocking acquire - Add round-robin connection selection to SQLite read pool - Add configurable flush_on_append to FileEventLog for deferred flushing - Document batch size recommendations for EventProcessor Documentation: - Correct preflight cache docs from LRU to FIFO eviction policy - Add comprehensive SyncMode durability/performance docs - Add Performance Tuning section to AGENTS.md Co-authored-by: Cursor <cursoragent@cursor.com>
c72e266 to
ee8808d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_tasks, strict input validation in DLQ replayerByErrorType, and SQL identifier validation inazoth-vectorVectorSearch::newto prevent injection via table/column names.IpfsProvidernow redactsapi_keyandsecret_keyfromDebugoutput to prevent accidental exposure in logs. Unsafe extension loading inazoth-vectoris documented with safety requirements.FileEventLoggains a configurableflush_on_appendoption for deferred flushing.SyncModedurability docs; documentedEventProcessorbatch size recommendations; added a Performance Tuning section toAGENTS.md.Files Changed (15)
azoth-scheduler/src/projection.rs,azoth/src/dlq_replayer.rs,azoth-vector/src/search.rs,azoth-vector/src/extension.rs,azoth/src/ipfs.rsazoth-lmdb/src/read_pool.rs,azoth-sqlite/src/read_pool.rs,azoth-file-log/src/store.rs,azoth/benches/basic_benchmark.rsAGENTS.md,azoth-core/src/config/canonical.rs,azoth-lmdb/src/preflight_cache.rs,azoth/src/event_processor.rsazoth-vector/src/lib.rs,azoth-vector/tests/integration_test.rsVectorSearch::newreturningResultTest plan
cargo check --workspacepassescargo clippy --workspacepasses with no warningscargo test --workspace– all 183 tests passtest_replay_priority_by_error_type_validation,test_identifier_validation_rejects_injectionMade with Cursor