Skip to content

Conversation

@Davidmattei
Copy link
Member

@Davidmattei Davidmattei commented Oct 8, 2024

  • For fixing the build the tests are now using the restore command

  • sleep .25s was not working on mac converted to sleep 25

  • Remove the following because also not working on mac environment

type ${BATS_CONTAINER_COMPOSE_ENGINE} &>/dev/null || ( echo "${BATS_CONTAINER_COMPOSE_ENGINE} is not available"; exit 1 ) 
  • Added port forward for ems and emsch (easy for debugging

If pr approved, I will also apply on the admin and rebuild the 5.22.0 image

@Davidmattei Davidmattei requested a review from zebby76 October 8, 2024 21:19
Copy link
Contributor

@zebby76 zebby76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with success on :

  • Ubuntu 22.04 via Docker (docker-desktop)
  • Fedora 40 via Podman (podman-desktop)

@Davidmattei Davidmattei merged commit c0bf4c9 into 5.22 Oct 9, 2024
5 checks passed
@zebby76 zebby76 deleted the fix-build branch May 21, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants