[Asyncify] Hint at the stack size possibly being the issue when hitting "unreachable" #18085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Oct 24, 2022
test/test_other.py
Outdated
| self.assertContained('[asyncify] i can', out) | ||
|
|
||
| def test_asyncify_stack_overflow(self): | ||
| args = ['-sASYNCIFY', '-sASYNCIFY_STACK_SIZE=4'] |
There was a problem hiding this comment.
self.emcc_args += (these will be added automatically to the emcc_args specified via the parameter below.
sbc100
reviewed
Oct 24, 2022
test/test_other.py
Outdated
| # The unreachable error on small stack sizes is not super-helpful. Try at | ||
| # least to hint at increasing the stack size. | ||
|
|
||
| self.do_runf(test_file('other/async_stack_overflow.cpp'), |
There was a problem hiding this comment.
Can you rename this file to match the test name?
sbc100
approved these changes
Oct 24, 2022
|
Thanks, feedback should be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #17567
Also move the test from the browser suite to other. It's easier to test there and it's faster.