Skip to content

Conversation

@walkingeyerobot
Copy link
Collaborator

Adding some detail that @trybka and I have found useful in debugging.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually useful in practice or does wasm_opt always the dominant?

lgtm either way I guess more information is always better.

@walkingeyerobot
Copy link
Collaborator Author

wasm_opt has always been dominant, but this way we know explicitly what percentage of the "binaryen" block it is.

@sbc100 sbc100 enabled auto-merge (squash) November 3, 2022 21:31
@sbc100 sbc100 merged commit da8c8f8 into emscripten-core:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants