[embind] Support annotating return values as nonnull. #22567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embind's subclass `implement` methods were generated as returning `Class | null` after the changes to pointer types in emscripten-core#22184. This could be considered a regression as the implement method would never return null. Previously, we had special handling so constructors were marked as nonnull so in the TS definitions we didn't add `| null`. I've generalized this approach to work for all function bindings so they can now use a `nonnull<ret_val>` policy too avoid the `| null`.
kripken
reviewed
Sep 16, 2024
|
(lgtm otherwise!) |
|
(also maybe mention in the changelog? but that can be with the docs - if docs are in a later PR, can wait on that) |
|
I added some docs and a changelog entry. |
kripken
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embind's subclass
implementmethods were generated as returningClass | nullafter the changes to pointer types in #22184. This could be considered a regression as the implement method would never return null.Previously, we had special handling so constructors were marked as nonnull so in the TS definitions we didn't add
| null. I've generalized this approach to work for all function bindings so they can now use anonnull<ret_val>policy too avoid the| null.