Cleanup wasm worker tests. NFC #22749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
wasm_worker_test
branch
from
fbc3e2d to
ef3562f
Compare
kripken
approved these changes
Oct 16, 2024
- Use `emscripten_out` helper instead of EM_ASM(out(...)). - Remove tabs - Curly braces on the same line as keyword - Parameterize one test
sbc100
force-pushed
the
wasm_worker_test
branch
from
ef3562f to
8d402f3
Compare
kripken
reviewed
Oct 16, 2024
| #include <stdlib.h> | ||
|
|
||
| #define THREAD_STACK_SIZE 1024 | ||
| #define THREAD_STACK_SIZE 2048 |
Member
There was a problem hiding this comment.
Stack size change because of emscripten_outf?
Collaborator
Author
There was a problem hiding this comment.
Yup, essentially printf. The exact side of the stack in this test is not super important though I think. I just designed to ensure that stack start/end match our expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emscripten_outhelper instead of EM_ASM(out(...)).