Decouple libwasm_workers from MTLibrary. NFC #22750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Oct 16, 2024
The MTLibrary subclass is designed for libraries that build in all different modes. I think the wasm_workers library and the plans pthreads library should not be inheriting from this class. This is needed for both emscripten-core#22683 and emscripten-core#22735.
sbc100
force-pushed
the
wasm_workers_library
branch
from
89218fc to
d4f780e
Compare
kripken
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MTLibrary subclass is designed for libraries that build in all different modes. I think the wasm_workers library and the planned pthreads library should not be inheriting from this class.
This is needed for both #22683 and #22735.