Run test_chmod under NODERAWFS. NFC #23004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 25, 2024
sbc100
force-pushed
the
also_with_wasmfs_and_rawfs
branch
3 times, most recently
from
ce6fc7e to
b5119cb
Compare
kripken
reviewed
Nov 25, 2024
sbc100
force-pushed
the
also_with_wasmfs_and_rawfs
branch
3 times, most recently
from
124c977 to
8293f94
Compare
kripken
approved these changes
Nov 25, 2024
sbc100
force-pushed
the
also_with_wasmfs_and_rawfs
branch
from
8293f94 to
1b82cf3
Compare
sbc100
force-pushed
the
also_with_wasmfs_and_rawfs
branch
from
1b82cf3 to
fb81f62
Compare
|
@sbc100 It looks like this is causing failures on windows https://chromium-review.googlesource.com/c/emscripten-releases/+/6051557 |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 26, 2024
This test depends on separate R/W/X permission bits that windows lacks. Followup to emscripten-core#23004
sbc100
added a commit
that referenced
this pull request
Nov 26, 2024
This test depends on separate R/W/X permission bits that windows lacks. Followup to #23004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.