-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[docs] Document limitation on std::set_terminate and __cxa_begin_catch #23728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3526475
[docs] Document limitation on std::set_terminate
aheejin b6f7831
Update site/source/docs/porting/exceptions.rst
aheejin c6940b2
Document about __cxa_begin_catch too
aheejin 591b4ad
Merge branch 'main' into doc_set_terminate
aheejin d3b43e4
Reword
aheejin 99bad19
Merge branch 'main' into doc_set_terminate
aheejin b747cd2
Add example to the first point
aheejin e13ded9
Limitations regarding std::terminate()
aheejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would writing
std::terminate()
here have the same effect?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case there's no exception so
__cxa_begin_catch
is (correctly) not called and the program (correctly) printsexception_ptr is null
, so it does not show the bug (or limitation) here.