Move add/removeRunDependency to library code. NFC #24952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
move_run_deps
branch
2 times, most recently
from
6edb731 to
3db2108
Compare
kripken
reviewed
Aug 18, 2025
kripken
reviewed
Aug 18, 2025
kripken
approved these changes
Aug 18, 2025
This change just moves the code in the JS library. For now we still included these symbol unconditionally. I follow up by trying to limit the inclusion to when its actually needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just moves the code in the JS library. For now we still included these symbol unconditionally. I follow up by trying to limit the inclusion to when its actually needed.