Fix weak symbol handling when loading multiple dynamic libraries. #25244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_weak_imports
branch
from
25f1f83 to
941eaec
Compare
Collaborator
Author
|
I simplified the test case an converted it to C |
dschuff
approved these changes
Sep 10, 2025
The `currentModuleWeakSymbols` global was being set the wrong time which would lead to the wrong set of symbols being used for a given dylib. Also have another version of this change that removes the global completely but this one is simpler. Fixes: emscripten-core#25214
sbc100
force-pushed
the
fix_weak_imports
branch
from
941eaec to
8314cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
currentModuleWeakSymbolsglobal was being set the wrong time which would lead to the wrong set of symbols being used for a given dylib.Also have another version of this change that removes the global completely but this one is simpler.
Fixes: #25214