Don't build MAIN_MODULE as RELOCATABLE #25522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
main_module_static_v2
branch
2 times, most recently
from
cd1b8ce to
e8f95c7
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
Also, add an assertion to dynCall. Split out from emscripten-core#25522.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
Also, add an assertion to dynCall. Split out from emscripten-core#25522.
sbc100
force-pushed
the
main_module_static_v2
branch
2 times, most recently
from
8c32591 to
d40087a
Compare
|
I still need to get some stats on the benefits of this, but that tests are all now passing so I think this should be good to review now. An open question is: What do we do about |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
Also, add an assertion to dynCall. Split out from emscripten-core#25522.
sbc100
force-pushed
the
main_module_static_v2
branch
from
d40087a to
6008112
Compare
|
Yeah, I see what you mean, removing RELOCATABLE first would simplify this a little. I don't have a preference though. I do see some tests still fail here though? |
sbc100
added a commit
that referenced
this pull request
Oct 22, 2025
Also, add an assertion to dynCall. Split out from #25522.
sbc100
force-pushed
the
main_module_static_v2
branch
from
6008112 to
57b299d
Compare
The main advantage here is that main module no longer requires relocation entries for symbols defined locally. Fixes: emscripten-core#12682
sbc100
force-pushed
the
main_module_static_v2
branch
from
57b299d to
9c4dc95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My second or third attempt at this now :)
Fixes: #12682