[ci] Split wasm64 misc tests into their own runner. NFC #25536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this we were tacking on the extra misc tests on the end of wasm64-4gb runner.
Member
|
What is the advantage to this split? Is it faster overall? |
Collaborator
Author
Its likely fast yes, but mostly its just organizational. I don't like lumping in these misc tests with the runner called |
kripken
approved these changes
Oct 9, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Ok, lgtm, but maybe measure to make sure this isn't wasteful (maybe there are so few misc tests that the general job overhead is high compared to them).
Collaborator
Author
This job takes 5 mins to run, and only a few seconds to setup so I think its worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this we were tacking on the extra misc tests on the end of wasm64-4gb runner.