Skip to content

Lower minimum supported Node.js version for Wasm Exnref EH #25651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

Lower minimum supported Node.js version for Wasm Exnref EH #25651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d597e8c
Lower minimum supported Node.js version for Wasm Exnref EH
kleisauke Oct 26, 2025
82f0ccf
Merge branch 'main' into lower-wasm-exnref-feature
kleisauke Oct 26, 2025
fd72b1e
Lower in test suite too
kleisauke Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ def require_wasm_eh(self):
if 'EMTEST_SKIP_WASM_EH' in os.environ:
self.skipTest('test requires node v24 or d8 (and EMTEST_SKIP_WASM_EH is set)')
self.set_setting('WASM_LEGACY_EXCEPTIONS', 0)
if self.try_require_node_version(24):
if self.try_require_node_version(22):
self.node_args.append('--experimental-wasm-exnref')
return

Expand Down
2 changes: 1 addition & 1 deletion tools/feature_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class Feature(IntEnum):
# unflagged version of Node.js 260000 that ships Wasm EH enabled, after
# Emscripten unit testing has migrated to Node.js 26, and Emsdk ships
# Node.js 26)
'node': 240000,
'node': 220000,
},
}

Expand Down