Skip to content

Conversation

@juj
Copy link
Collaborator

@juj juj commented Oct 27, 2025

In previous PR #25644 I added -wait-for-browser use on Windows to help single-threaded Windows runner not leave behind stale browser windows.

For some reason, it was not passing on CircleCI on Linux. Testing this again to see what the failure is.

In local testing with a test script:

import subprocess, sys, time

cmd = ['C:\\Program Files\\Mozilla Firefox\\firefox.exe', '-new-instance', '-profile', sys.argv[1], '-wait-for-browser', 'https://wiki.mozilla.org/Firefox/CommandLineOptions']
print('Launching browser: ' + ' '.join(cmd))
proc = subprocess.Popen(cmd)

for i in range(10):
  if proc.poll() is not None:
    print('Oops: process already quit, so we did not get a process handle to keep track of the browser instance.')
    sys.exit(0)
  time.sleep(1)

if proc.poll() is None:
  print('terminating browser process')
  proc.terminate()
time.sleep(2)
if proc.poll() is None:
  print('terminating did not work. killing browser process')
  proc.kill()

print('All done')

I am unable to find a behavioral difference between Windows and Linux.

So testing this out again on CircleCI.

@juj
Copy link
Collaborator Author

juj commented Oct 27, 2025

Ok, figured out the issue. Reported as https://bugzil.la/1996614

@juj juj enabled auto-merge (squash) October 27, 2025 16:45
@juj juj merged commit 49fdd76 into emscripten-core:main Oct 27, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants