Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 27, 2025

Without this, one cannot do things like ./test/runner lto0.test_foo*.

Without this, one cannot do things like `./test/runner lto0.test_foo*`.
@sbc100 sbc100 requested review from juj and kripken October 27, 2025 19:00
@juj
Copy link
Collaborator

juj commented Oct 27, 2025

Oh so this is why running somesuite.test_foo* often fails. The suite must be in the list of passing_core_test_modes for the wildcard to work?

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 27, 2025

Oh so this is why running somesuite.test_foo* often fails. The suite must be in the list of passing_core_test_modes for the wildcard to work?

Yes... probably we should fix that .. but that seems to be how it works today.

@sbc100 sbc100 merged commit 2e4fdb0 into emscripten-core:main Oct 27, 2025
34 checks passed
@sbc100 sbc100 deleted the lto_test_suites branch October 27, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants