Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 13, 2025

No description provided.

@sbc100 sbc100 requested a review from dschuff November 13, 2025 23:55
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 13, 2025

I'm not sure I can even test this without landing it first :(

name: Update website
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to add this token to the emscripten-site repo in order to open PRs there?

@dschuff @kripken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the emscripten-site repo will accept PRs from any random person on github, then I don't see why emscripten-bot should be different. If we need to give emscripten-bot some permission to let CI on the site run, we could do that. But it shouldn't require actually putting the bot's token in the repo as a secret. That would only be needed if we want something to run as the bot.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 14, 2025

Landing TBR so I can test

@sbc100 sbc100 merged commit 51b9914 into emscripten-core:main Nov 14, 2025
30 of 34 checks passed
@sbc100 sbc100 deleted the update_docs branch November 14, 2025 00:36
@dschuff
Copy link
Member

dschuff commented Nov 14, 2025

You should be able to manually trigger workflows on any particular branch,

Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like this would allow manually triggering the workflow.

@@ -0,0 +1,50 @@
name: Update website

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
on:
workflow_dispatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants