Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 14, 2025

  • Ignore changes that only include AUTHORS.html
  • Use EMSCRIPTEN_BOT_TOKEN when checking out the -site repo since we need that in order to push to it
  • Move -site repo checkout to within the emscripten checkout.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 14, 2025

I'm now able to manually trigger the update-website action from this PR branch so I think we can iterate here until its working.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 14, 2025

I'm seeing:

remote: Permission to kripken/emscripten-site.git denied to github-actions[bot].
247
fatal: unable to access 'https://github.com/kripken/emscripten-site/': The requested URL returned error: 403

which I guess makes sense since we are trying to push directly rather than to a fork.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 14, 2025

@dschuff any idea where the best place to start is? Should we add emscripten-bot@ as a collaborator on the emscripten-site or do we need to issue some new token.

@sbc100 sbc100 closed this Nov 14, 2025
@sbc100 sbc100 reopened this Nov 14, 2025
@sbc100 sbc100 requested a review from kripken November 14, 2025 01:11
@sbc100 sbc100 force-pushed the update_docs branch 16 times, most recently from da3c9f6 to 0424a0f Compare November 14, 2025 03:08
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I don't know anything about the token stuff

@dschuff
Copy link
Member

dschuff commented Nov 14, 2025

We discussed this a bit offline, but for the record, when you use the token here, the actions should be done with the permissions of @emscripten-bot (so the fact that github-actions[bot] is showing up here means the token isn't being used). We can add give @emscripten-bot permission to push to the site, or we can let it use its own fork and push to that, and then it should be able to open PRs against the site without any special permissions.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 14, 2025

Turns out it was the checkout action that was fucking things up since it was overriding the auth method for the repo. Using token: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }} during checkout fixed the issue.

@sbc100 sbc100 force-pushed the update_docs branch 3 times, most recently from e45b755 to f465d26 Compare November 14, 2025 23:46
@sbc100 sbc100 changed the title [CI] Attempt to fix update-website.yml [CI] Fix update-website.yml Nov 15, 2025
@sbc100 sbc100 requested a review from kripken November 15, 2025 00:06
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 15, 2025

OK this seems to be working now. I think we should be good to land. PTAL

Co-authored-by: Alon Zakai <azakai@google.com>
@sbc100 sbc100 merged commit de1310e into main Nov 15, 2025
1 of 16 checks passed
@sbc100 sbc100 deleted the update_docs branch November 15, 2025 00:14
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }}
GITHUB_TOKEN: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that this doesn't actually matter; gh respects both for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants