-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CI] Fix update-website.yml #25796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix update-website.yml #25796
Conversation
|
I'm now able to manually trigger the update-website action from this PR branch so I think we can iterate here until its working. |
|
I'm seeing: which I guess makes sense since we are trying to push directly rather than to a fork. |
|
@dschuff any idea where the best place to start is? Should we add |
da3c9f6 to
0424a0f
Compare
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I don't know anything about the token stuff
|
We discussed this a bit offline, but for the record, when you use the token here, the actions should be done with the permissions of @emscripten-bot (so the fact that github-actions[bot] is showing up here means the token isn't being used). We can add give @emscripten-bot permission to push to the site, or we can let it use its own fork and push to that, and then it should be able to open PRs against the site without any special permissions. |
|
Turns out it was the |
e45b755 to
f465d26
Compare
|
OK this seems to be working now. I think we should be good to land. PTAL |
Co-authored-by: Alon Zakai <azakai@google.com>
| runs-on: ubuntu-latest | ||
| env: | ||
| GH_TOKEN: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.EMSCRIPTEN_BOT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out that this doesn't actually matter; gh respects both for some reason.
-siterepo since we need that in order to push to it-siterepo checkout to within the emscripten checkout.