-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix browser test runner on macOS Safari. #25799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Landing to fix CI. |
|
I don't know if this is related, but I merged "main", which contains your changes, in my PR and now there is a failing test related to firefox as well: |
|
This PR should only affect execution on macOS, when Safari is being launched. The error message suggests something has changed in chocolatey.
Maybe something updated in chocolatey, now causing this error? I am not sure, I have not used chocolatey. Maybe @brendandahl or @sbc100 might know more around that area? |
| return UNSUPPORTED | ||
| plist_path = os.path.join(EMTEST_BROWSER.strip(), 'Contents', 'version.plist') | ||
| version_str = plistlib.load(read_binary(plist_path)).get('CFBundleShortVersionString') | ||
| version_str = plistlib.load(open(plist_path, 'rb')).get('CFBundleShortVersionString') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah can we change this to loads(read_binary..) maybe ?
That just looks like an intermitent network failure of some kind. it can happen from time to time with Sadly this is the nature of depend on external services in our CI. |
No description provided.