Skip to content

Conversation

@juj
Copy link
Collaborator

@juj juj commented Nov 14, 2025

No description provided.

@juj
Copy link
Collaborator Author

juj commented Nov 14, 2025

Landing to fix CI.

@juj juj merged commit caabcdb into emscripten-core:main Nov 14, 2025
9 of 16 checks passed
@ypujante
Copy link
Contributor

I don't know if this is related, but I merged "main", which contains your changes, in my PR and now there is a failing test related to firefox as well:

https://app.circleci.com/pipelines/github/emscripten-core/emscripten/47488/workflows/46fe58c5-9474-4a27-ae66-cae3c1551fc2/jobs/1078184

pkgconfiglite v0.28.0
pkgconfiglite package files install completed. Performing other installation steps.
Downloading pkgconfiglite 64 bit
  from 'http://downloads.sourceforge.net/project/pkgconfiglite/0.28-1/pkg-config-lite-0.28-1_bin-win32.zip'
Progress: 100% - Completed download of C:\Users\circleci\AppData\Local\Temp\chocolatey\pkgconfiglite\0.28.0\pkg-config-lite-0.28-1_bin-win32.zip (46.57 KB).
Download of pkg-config-lite-0.28-1_bin-win32.zip (46.57 KB) completed.
WARNING: Missing package checksums are not allowed (by default for HTTP/FTP, 
 HTTPS when feature 'allowEmptyChecksumsSecure' is disabled) for 
 safety and security reasons. Although we strongly advise against it, 
 if you need this functionality, please set the feature 
 'allowEmptyChecksums' ('choco feature enable -n 
 allowEmptyChecksums') 
 or pass in the option '--allow-empty-checksums'. You can also pass 
 checksums at runtime (recommended). See choco install -? for details.
The integrity of the file 'pkg-config-lite-0.28-1_bin-win32.zip' from 'http://downloads.sourceforge.net/project/pkgconfiglite/0.28-1/pkg-config-lite-0.28-1_bin-win32.zip' has not been verified by a checksum in the package scripts.
Do you wish to allow the install to continue (not recommended)?
[Y] Yes [N] No (default is "N")
  Confirmation (`-y`) is set.
  Respond within 30 seconds or the default selection will be chosen.
ERROR: Empty checksums are no longer allowed by default for non-secure sources. Please ask the maintainer to add checksums to this package. In the meantime if you need this package to work correctly, please enable the feature allowEmptyChecksums, provide the runtime switch '--allow-empty-checksums', or pass in checksums at runtime (recommended - see 'choco install -?' / 'choco upgrade -?' for details). It is strongly advised against allowing empty checksums for non-internal HTTP/FTP sources.
The install of pkgconfiglite was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\pkgconfiglite\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 2/3 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - pkgconfiglite (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\pkgconfiglite\tools\chocolateyInstall.ps1'.
 See log for details.

Exited with code exit status 127

@juj
Copy link
Collaborator Author

juj commented Nov 14, 2025

This PR should only affect execution on macOS, when Safari is being launched.

The error message suggests something has changed in chocolatey.

ERROR: Empty checksums are no longer allowed by default for non-secure sources.

Maybe something updated in chocolatey, now causing this error? I am not sure, I have not used chocolatey. Maybe @brendandahl or @sbc100 might know more around that area?

return UNSUPPORTED
plist_path = os.path.join(EMTEST_BROWSER.strip(), 'Contents', 'version.plist')
version_str = plistlib.load(read_binary(plist_path)).get('CFBundleShortVersionString')
version_str = plistlib.load(open(plist_path, 'rb')).get('CFBundleShortVersionString')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah can we change this to loads(read_binary..) maybe ?

@sbc100
Copy link
Collaborator

sbc100 commented Nov 14, 2025

This PR should only affect execution on macOS, when Safari is being launched.

The error message suggests something has changed in chocolatey.

ERROR: Empty checksums are no longer allowed by default for non-secure sources.

Maybe something updated in chocolatey, now causing this error? I am not sure, I have not used chocolatey. Maybe @brendandahl or @sbc100 might know more around that area?

That just looks like an intermitent network failure of some kind. it can happen from time to time with npm and with pip and also with chocolaty (the windows package manager).

Sadly this is the nature of depend on external services in our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants