Move emscripten lld flags to start start of cmd line #25803
Conversation
Is this perhaps going to break some users that depended on the current order? |
The only users who might be effected are those that pass wasm-specific IMHO this behaviour is more correct. If a users specifies Its a very unlikely use case though.. since how/why would such as flag ever have been added but such a user if was to be ignored anyway. I will add a ChangeLog entry just in case anyway. |
sbc100
force-pushed
the
lld_flags_for_executable
branch
4 times, most recently
from
ef708d4 to
d88945d
Compare
This allows the `-Bdynamic` flag to be moved there which is its logical place. It also theoretically allows user flags to override any system flags.
sbc100
force-pushed
the
lld_flags_for_executable
branch
from
d88945d to
fe7d05c
Compare
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm with a test - as you say the new behavior is more correct, let's make sure we continue to have that behavior
|
Oops, I didn't notice automerge... |
2 participants
This allows the
-Bdynamicflag to be moved there which is its logical place. It also theoretically allows user flags to override any system flags.