Avoid using --proxy-to-worker for tests that need to run in a worker. NFC
#25816
+29
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 18, 2025
sbc100
force-pushed
the
workerfs_no_proxy
branch
4 times, most recently
from
1d6e3de to
17eb7a1
Compare
sbc100
changed the title
--proxy-to-worker in workerfs tests. NFC--proxy-to-worker for tests that need to run in a worker. NFC
Collaborator
Author
|
Ok, this should be good to review now. Sorry about that. |
Member
|
Since |
Collaborator
Author
Yes we have a lot of specific tests for it. And many test marked with |
This lays the groundwork removing the `--proxy-to-worker` features completely.
sbc100
force-pushed
the
workerfs_no_proxy
branch
from
17eb7a1 to
67963e7
Compare
dschuff
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are not specific to
--proxy-to-worker, but are merely testing that stuff runs in worker.This lays the groundwork removing the
--proxy-to-workerfeature completely.