Fix Firefox 91 ESR and Firefox 102 ESR test runs #25835
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture check to fix Firefox 91 ESR and Firefox 102 ESR test runs.
sbc100
reviewed
Nov 20, 2025
| # This test create a second HTTP server running a different port that servers files from `subdir`. | ||
| # The main html is the servers from the normal 8888 server while the JS and Wasm are hosted | ||
| if '-sEXPORT_ES6' in args and browser_should_skip_feature('EMTEST_LACKS_ES6_WORKERS', Feature.WORKER_ES6_MODULES): | ||
| self.skipTest('This test requires a browser with ES6 Module Workers support') |
Collaborator
There was a problem hiding this comment.
I guess we should have a method version of @requires_es6_workers decorator. But this LGTM for now.
Collaborator
Author
There was a problem hiding this comment.
Yeah, the awkwardness of decorators not combining well with these parameterized modes repeats in many tests. That would be a bit of a cleanup refactor to figure out how to create a simple pattern that would work well in both.
sbc100
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25823 added a new ES6 Worker test. Gate it behind feature check to fix Firefox 91 ESR and Firefox 102 ESR test runs.