Skip to content

Conversation

@ypujante
Copy link
Contributor

@ypujante ypujante commented Nov 21, 2025

Fixes: #25846

Iterating and removing ALL instances of a given listener.

I wanted to add a test for this use case, but I am not sure how I would do that. Is there a way to have a test that targets Safari? And have the code of the test do something different in this case?

@ypujante
Copy link
Contributor Author

I tried to fix the code size test failure, but once again I am unsuccessful. I reverted the (code size) change since it is wrong anyway.

@sbc100 sbc100 enabled auto-merge (squash) November 21, 2025 19:52
@sbc100 sbc100 changed the title Fixes emscripten_html5_remove_event_listener when multiple listeners (#25846) Fixes emscripten_html5_remove_event_listener when multiple listeners Nov 21, 2025
@sbc100 sbc100 merged commit a58305a into emscripten-core:main Nov 21, 2025
34 checks passed
@ypujante
Copy link
Contributor Author

I apologize for not being able to run the codesize myself. I try but it just doesn't give the right results and I just don't know why. In any case, thank you for doing it.

@sbc100
Copy link
Collaborator

sbc100 commented Nov 21, 2025

I apologize for not being able to run the codesize myself. I try but it just doesn't give the right results and I just don't know why. In any case, thank you for doing it.

Its very strange. Must be some kind of configuration issue but I can't guess what it might be. I think we tried all the things I could think of.

Oh, there was one other cause of discrpency that can stem from the version of zlib on you system. Can you confirm, when you see discrepancies is it only the gz compressed sizes?

@ypujante
Copy link
Contributor Author

From this commit 9265ba4 it doesn't look like it was just the zip files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emscripten_html5_remove_event_listener does not clean fullscreenchange entirely

2 participants