Remove WIN32 and APPLE references from Emscripten.cmake. NFC #25855
+4
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are the toolchain file we decide what to set and no other toolchain file should be setting these. We have tests that confirm that these are indeed not set. Also move the setting if `CMAKE_DL_LIBS` which it is not related to `CMakeBackwardCompatibilityC.cmake` (which also had a typo in the name).
juj
reviewed
Nov 22, 2025
| # This feature is activated if a shared library project has the property | ||
| # SOVERSION defined. | ||
| set(CMAKE_SHARED_LIBRARY_SONAME_C_FLAG "-Wl,-soname,") | ||
| set(CMAKE_DL_LIBS "") |
Collaborator
There was a problem hiding this comment.
This is setting the variable to an empty string, whereas the previous code was unsetting the variable. Does that matter?
Collaborator
Author
There was a problem hiding this comment.
This is what other plaforms seem to do upstream. They seem to either use the empty string or the string "dl"
juj
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are the toolchain file we decide what to set and no other toolchain file should be setting these. We have tests that confirm that these are indeed not set.
Also move the setting if
CMAKE_DL_LIBSwhich it is not related toCMakeBackwardCompatibilityC.cmake(which also had a typo in the name).