Add LSan and ASan test modes to non_core_test_modes #9011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows glob patterns like `asan.test_a*` to be used on ASan and LSan tests.
kripken
approved these changes
Jul 17, 2019
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm
btw I see these modes don't have an -O flag, is it intentional they are just on unoptimized code?
Member
Author
|
I did not want to add too many modes for sanitizers. My impression is that sanitizers will most commonly be used without optimization, so I am intentionally just testing that. |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…9011) This allows glob patterns like `asan.test_a*` to be used on ASan and LSan tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows glob patterns like
asan.test_a*to be used on ASan and LSan tests.