Make STACK_BASE refer to the starting stack location on threads #9033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already a case on the main thread. However, on WASM backend, STACK_BASE == STACK_MAX == the lowest address on the stack, i.e. the point where the stack can grow to. This makes it impossible to find the highest address on the stack, i.e. the bottom of the stack. This PR makes the behaviour consistent between the main thread and other threads by making other threads follow the conventions of the main thread.
quantum5
commented
Jul 19, 2019
| #if WASM_BACKEND | ||
| assert(max === e.data.stackBase); | ||
| assert(top > max); | ||
| assert(e.data.stackBase == max); |
Member
Author
There was a problem hiding this comment.
This assertion is redundant.
sbc100
approved these changes
Jul 19, 2019
dschuff
approved these changes
Jul 19, 2019
Member
|
It would be good to add a testcase for this - something that fails only before the fix. |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ripten-core#9033) This is already a case on the main thread. However, on WASM backend, STACK_BASE == STACK_MAX == the lowest address on the stack, i.e. the point where the stack can grow to. This makes it impossible to find the highest address on the stack, i.e. the bottom of the stack. This PR makes the behaviour consistent between the main thread and other threads by making other threads follow the conventions of the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already a case on the main thread. However, on WASM backend,
STACK_BASE == STACK_MAX ==the lowest address on the stack, i.e. the point where the stack can grow to. This makes it impossible to find the highest address on the stack, i.e. the bottom of the stack.This PR makes the behaviour consistent between the main thread and other threads by making other threads follow the conventions of the main thread.
We shall see if the tests pass.