Remove Fastcomp's Asyncify, which has been deprecated for years #9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jul 24, 2019
| self.do_run(src, '*leaf-0-100-1-101-1-102-2-103-3-104-5-105-8-106-13-107-21-108-34-109-*') | ||
|
|
||
| @no_wasm_backend('ASYNCIFY coroutines are not yet supported in the LLVM wasm backend') | ||
| @no_fastcomp('ASYNCIFY has been removed from fastcomp') |
Member
There was a problem hiding this comment.
Is there a simpler way to skip a test entirely?
Member
Author
There was a problem hiding this comment.
Not atm. Once we remove fastcomp this will look less silly...
| self.do_test_coroutine({'ASYNCIFY': 1}) | ||
|
|
||
| @no_wasm_backend('ASYNCIFY is not supported in the LLVM wasm backend') | ||
| @no_fastcomp('ASYNCIFY has been removed from fastcomp') |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ripten-core#9075) This was deprecated around when Emterpreter-Async came around, which was a long time ago. Also we now have a new Asyncify in the upstream backend, so it's a good time to remove the old one. This will also make work on the new one easier (e.g. it had a whitelist already, and supporting two variants would be annoying). People that still need Asyncify can use an older version (1.38.40), but upgrading to upstream and the new Asyncify is recommended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was deprecated around when Emterpreter-Async came around, which was a long time ago. Also we now have a new Asyncify in the upstream backend, so it's a good time to remove the old one.
This will also make work on the new one easier (e.g. it had a whitelist already, and supporting two variants would be annoying).
People that still need Asyncify can use an older version (1.38.40), but upgrading to upstream and the new Asyncify is recommended.