[Bazel] Remove dependency on system python on Windows too#1681
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 26, 2026
Merged
[Bazel] Remove dependency on system python on Windows too#1681sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
|
Seems like the right direction to me. Why would one ever not want to use the hermetic python? |
sbc100
approved these changes
Feb 26, 2026
Contributor
Author
|
On Windows the hermetic python toolchain can be extremely slow, that's why we had avoided it until now, but functionally it's the same. |
Collaborator
|
How is the hermetic python slower? Do you mean when its first installed? Or is the python executable somehow different/slower? |
Contributor
Author
|
It has something to do with the way the python rules build the .exes of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #1676.
Just a heads up with those changes (and the ones from #1676), things will not work anymore for projects that don't use an hermetic python toolchain because the interpreter will not be found.
Using the system python is not a great idea anyway, but I just wanted to mention that because that forced our hand in adopting the hermetic toolchain (we were planing on doing it at a later date), and I don't know if this had been considered in #1676.