NXT-13229: Updated Card to match the latest GUI#344
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #344 +/- ##
========================================
Coverage 81.86% 81.86%
========================================
Files 153 153
Lines 7476 7477 +1
Branches 2249 2250 +1
========================================
+ Hits 6120 6121 +1
Misses 1048 1048
Partials 308 308 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Done |
daniel-stoian-lgp
approved these changes
May 15, 2026
dan-ichim-lgp
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
I updated Card to match the latest GUI requirements
Resolution
Additional Considerations
In the design, it was requested that the container for the component does not change size for large text. In order to fit the new text with captions, label, and secondary label the design provided the solution of reducing the size of the image.
I added height:~"calc(var(--card-image-height) - 36px) for label where 36 was chosen because was the difference between all the line-height added to captions.
Links
NXT-13229
Comments