-
Notifications
You must be signed in to change notification settings - Fork 8
Add Travis config to run rustfmt test #22
Conversation
2039b32 to
54d32ae
Compare
|
I've amended the tests to also run in the |
|
One pull request with two commits please. |
54d32ae to
5ed2585
Compare
|
I can't believe I missed the obvious solution to all this. Make the parent directory a Cargo workspace. https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html |
5ed2585 to
46e1d7b
Compare
|
Agreed, that is the cleanest way to get what we need. How should I approach making that change? Separate commit adding the workspace before adding |
|
Yup. Logical commits. |
9ac8ce9 to
4cf0cd4
Compare
8423d83 to
938b6ab
Compare
e58ab99 to
ff6854e
Compare
|
@steveej I've reworded most of the commits; they should match up with the logical changes in each of them better now. |
adb2e24 to
44d2632
Compare
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thank you!
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having second thoughts on my previous approval, specifically because the generated lockfile has to generalize the dependencies isn't guaranteed to be consistent with all of the member crate lockfiles, or I don't understand the consistency here ;-) The issue I'm seeing is that the generated lockfile can bump dependencies which are used in tests from the root of the workspace, which are different from the one inside the members.
52d880d to
96c59a7
Compare
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made change to the ketuvim (enarx-archive/ketuvim#8) so that it re-exports the sev crate. This alleviates the following issue, which arises when pinning sev in ketuvim to a different version than it's using internally:
error[E0308]: mismatched types
--> amd-sev/src/main.rs:131:19
|
131 | launch.inject(secret, addr, len).unwrap();
| ^^^^^^ expected struct `sev::launch::Secret`, found a different struct `sev::launch::Secret`
|
= note: expected type `sev::launch::Secret` (struct `sev::launch::Secret`)
found type `sev::launch::Secret` (struct `sev::launch::Secret`)
note: Perhaps two different versions of crate `sev` are being used?
--> amd-sev/src/main.rs:131:19
|
131 | launch.inject(secret, addr, len).unwrap();1c58e91 to
107869b
Compare
107869b to
eb768d8
Compare
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the last one on the issue of reproducibility. After that we'll get to what cargo audit has to tell us.
eb768d8 to
801368e
Compare
steveej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking through this! :-)
To enforce proper formatting standards on Enarx projects, we'd like to run cargo fmt on all incoming pull requests to Enarx projects. This enables the appropriate test using Travis CI.
Resolves #11.