Skip to content

test new workflows#46

Merged
enaut merged 1 commit intomainfrom
test-new-workflows
Jul 14, 2025
Merged

test new workflows#46
enaut merged 1 commit intomainfrom
test-new-workflows

Conversation

@enaut
Copy link
Copy Markdown
Owner

@enaut enaut commented Jul 14, 2025

No description provided.

@enaut enaut requested a review from Copilot July 14, 2025 19:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the Docker build process by removing local cross-compilation Dockerfiles and the Cross.toml configuration in favor of dedicated GitHub Actions workflows for each architecture and a multi-arch manifest step.

  • Removed cross-*.Dockerfile and Cross.toml entries to deprecate local cross builds
  • Added build_docker_x86_64.yml and build_docker_arm64.yml workflows for separate AMD64 and ARM64 image builds
  • Introduced create_multiarch_image.yml to combine built images into a multi-architecture manifest and updated the workflow README

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cross-x86_64.Dockerfile Deleted local x86_64 cross-compilation Dockerfile
cross-aarch64.Dockerfile Deleted local aarch64 cross-compilation Dockerfile
Cross.toml Removed cross-rs build environment and target configurations
.github/workflows/create_multiarch_image.yml New job to assemble and push a multi-arch Docker manifest
.github/workflows/build_docker_x86_64.yml Updated to a reusable workflow for x86_64 builds
.github/workflows/build_docker_arm64.yml New ARM64 build-and-push workflow
.github/workflows/README.md Added documentation for the new split workflows
Comments suppressed due to low confidence (5)

.github/workflows/build_docker_arm64.yml:23

  • The runner label 'ubuntu-24.04-arm' is not a supported GitHub-hosted runner. Use a valid label like 'ubuntu-22.04' or 'ubuntu-latest' with an ARM runner.
    runs-on: ubuntu-24.04-arm

.github/workflows/build_docker_arm64.yml:92

  • The referenced Dockerfile './aarch64.Dockerfile' does not exist in the repo. Update the path to the correct filename or restore the missing Dockerfile.
          file: ./aarch64.Dockerfile

.github/workflows/build_docker_arm64.yml:70

  • [nitpick] Using a hyphen in the output variable name 'repo-owner' can complicate references. Consider using an underscore (e.g., 'repo_owner') for consistency and easier use.
          echo "repo-owner=$(echo ${{ github.repository_owner }} | tr 'A-Z' 'a-z')" >> $GITHUB_OUTPUT

.github/workflows/README.md:1

  • [nitpick] The README mixes German and English. Standardize on a single language to ensure clarity for all contributors.
# GitHub Actions Workflow-Aufteilung

.github/workflows/build_docker_x86_64.yml:13

  • [nitpick] The 'workflow_call' inputs and version–repo-owner setup are duplicated across both architecture workflows. Consider extracting common steps into a shared reusable workflow or composite action.
  workflow_call:

@enaut enaut merged commit 449a813 into main Jul 14, 2025
1 check passed
@enaut enaut deleted the test-new-workflows branch July 14, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants