Added GitHub action ci#11
Conversation
hramezani
force-pushed
the
github_action_ci
branch
from
3bb07f3 to
2091825
Compare
|
Could you please implement Tom's feedback to your PR so it follows conventions from other encode projects and also implements code coverage? Thanks! |
|
Sure! I will do them and will let you know. |
hramezani
force-pushed
the
github_action_ci
branch
from
2091825 to
7c8617f
Compare
|
@rafalp I made it like other encode project(httpx) as Tom mentioned. Please take a look and let me if there is anything else to do. |
hramezani
force-pushed
the
github_action_ci
branch
from
7c8617f to
78c82b8
Compare
| @@ -0,0 +1,10 @@ | |||
| #!/bin/sh -e | |||
There was a problem hiding this comment.
This file seems useless considered we don't have any docs for the lib.
There was a problem hiding this comment.
I've removed this script
| import typing | ||
| from typing import Any | ||
|
|
||
| from broadcaster._base import Event |
There was a problem hiding this comment.
This import should be relative.
| from .base import BroadcastBackend | ||
| from .._base import Event | ||
|
|
||
| from broadcaster._backends.base import BroadcastBackend |
There was a problem hiding this comment.
Those imports should be relative.
| from .base import BroadcastBackend | ||
| from .._base import Event | ||
|
|
||
| from broadcaster._backends.base import BroadcastBackend |
There was a problem hiding this comment.
Those imports should be relative.
|
|
||
| import asyncio_redis | ||
|
|
||
| from broadcaster._backends.base import BroadcastBackend |
There was a problem hiding this comment.
Those imports should be relative,
hramezani
force-pushed
the
github_action_ci
branch
from
78c82b8 to
4ce6c41
Compare
|
@rafalp I addressed your comments. |
|
Nice work, thank you! |
2 participants
Fixes #6.
I used GitHub action services instead of
docker-compose.