This repository was archived by the owner on Aug 19, 2025. It is now read-only.
[doc typos] Updated transactions documentation for low-level usage.#209
Merged
vmarkovtsev merged 2 commits intoencode:masterfrom Aug 10, 2020
Merged
[doc typos] Updated transactions documentation for low-level usage.#209vmarkovtsev merged 2 commits intoencode:masterfrom
vmarkovtsev merged 2 commits intoencode:masterfrom
Conversation
Using the lower-level API for Transactions requires that `await transaction.start()` is called so `transaction._connection` exists. Also, low-level usage of transactions did not include the use of `await` for `transaction.rollback()` and `.commit()`.
vmarkovtsev
approved these changes
Aug 10, 2020
Contributor
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
Whoa! How come that we missed this... Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documentation update only
Using the lower-level API for Transactions requires that
await transaction.start()is called sotransaction._connectionexists.
Also, low-level usage of transactions did not include the use of
awaitfortransaction.rollback()and.commit().