Small example code fixes#5944
Merged
carltongibson merged 2 commits intoencode:masterfrom Apr 20, 2018
Merged
Conversation
…really should have ben JWT and you are using djangorestframework-simplejwt then the action should look more like this: action = ['auth', 'token', 'obtain', 'create']
auvipy
approved these changes
Apr 19, 2018
carltongibson
previously requested changes
Apr 20, 2018
Collaborator
carltongibson
left a comment
carltongibson
left a comment
There was a problem hiding this comment.
Hi @ephes.
Thanks for this. All good except for the scheme change, which for "Django REST framework JWT" at least is JWT.
| result = client.action(schema, action, params) | ||
|
|
||
| auth = coreapi.auth.TokenAuthentication( | ||
| scheme='JWT', |
Collaborator
There was a problem hiding this comment.
This change isn't right.
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tried token authentication today and found those small errors. If it really should have ben JWT and you are using djangorestframework-simplejwt then the action should look more like this:
action = ['auth', 'token', 'obtain', 'create']