Skip to content

Drop stale unavailable pool connections#1084

Open
Mirochill wants to merge 1 commit into
encode:masterfrom
Mirochill:fix-1066-drop-stale-unavailable-connection
Open

Drop stale unavailable pool connections#1084
Mirochill wants to merge 1 commit into
encode:masterfrom
Mirochill:fix-1066-drop-stale-unavailable-connection

Conversation

@Mirochill
Copy link
Copy Markdown

Summary

  • remove an assigned connection from the pool if it still reports itself as available after raising ConnectionNotAvailable
  • prevent HTTP/2 connections that have received GOAWAY from advertising availability
  • add sync and async regression coverage for stale available connections

Closes #1066.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • Documentation is not updated because this is an internal connection-pool bug fix.

Validation

  • Local tests were not run because this workspace is intentionally coordination-only and does not run third-party project test suites locally.
  • Static validation only: git diff --check.
  • Relying on GitHub Actions for remote validation.

@Mirochill Mirochill force-pushed the fix-1066-drop-stale-unavailable-connection branch 5 times, most recently from f87199d to d718225 Compare May 20, 2026 12:49
@Mirochill Mirochill force-pushed the fix-1066-drop-stale-unavailable-connection branch from d718225 to 301e4c2 Compare May 20, 2026 12:52
@Mirochill Mirochill marked this pull request as ready for review May 20, 2026 12:59
@mbeijen
Copy link
Copy Markdown

mbeijen commented May 20, 2026

There are multiple PRs for similar issues open in this repository; but there has not been much activity lately. In httpxyz, most of these issues have now been fixed and I've been upstreaming fixes (not these ones yet) to httpx2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale connection stays in pool after ConnectionNotAvailable

2 participants