Add remove-all-unused-imports to autoflake invocation#210
Merged
jcugat merged 4 commits intoencode:masterfrom Oct 5, 2020
Merged
Add remove-all-unused-imports to autoflake invocation#210jcugat merged 4 commits intoencode:masterfrom
jcugat merged 4 commits intoencode:masterfrom
Conversation
cdeler
changed the title
jcugat
reviewed
Oct 5, 2020
Co-authored-by: Josep Cugat <jcugat@gmail.com>
jcugat
approved these changes
Oct 5, 2020
Contributor
|
As a followup we might want to add it to httpx too if we find it useful here 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8duringscript/testinvocation raises an error if we have unused imports.As
script/lintalready callsautoflake, we can add--remove-all-unused-imports --ignore-init-module-importsto the call, which might make development process easier