Skip to content

added docs for startup/shutdown of ASGI apps#1554

Merged
florimondmanca merged 2 commits intoencode:masterfrom
jkklapp:docs/start_up_shutdown_events
Apr 5, 2021
Merged

added docs for startup/shutdown of ASGI apps#1554
florimondmanca merged 2 commits intoencode:masterfrom
jkklapp:docs/start_up_shutdown_events

Conversation

@jkklapp
Copy link
Contributor

@jkklapp jkklapp commented Apr 4, 2021

Closes #1441


It is not in the scope of HTTPX to trigger lifespan events of your app.

However it is suggested to use `LifespanManager` from [asgi-lifespan](https://github.com/florimondmanca/asgi-lifespan#usage) in pair with `AsyncClient`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the examples below don't include any extra asgi-lifespan/HTTPX integration hints, should we drop everything below this line I'm commenting on? So as to avoid duplicate information. People can just click on the link and learn what asgi-lifespan is about and how to use it. There's even an HTTPX example in the README there. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 👍

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florimondmanca florimondmanca merged commit c1ccdbc into encode:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document solution for startup/shutdown of ASGI apps

2 participants