Merged
Conversation
florimondmanca
approved these changes
Aug 20, 2019
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Looks good to me as well :)
florimondmanca
suggested changes
Aug 20, 2019
florimondmanca
approved these changes
Aug 21, 2019
florimondmanca
force-pushed
the
refactor-interfaces
branch
from
119f80e to
45b893f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, so I think this is an improvement, in that it keeps all of our concurrency and dispatch stuff more isolated.
httpx/concurrency/base.pyhttpx/dispatch/base.py(Dispatcher, AsyncDispatcher)httpx/interfaces.pyCloses #249