Skip to content

Move utility functions from _utils.py to _multipart.py#3388

Merged
lovelydinosaur merged 1 commit intoencode:masterfrom
RafaelWO:change/move-utils-to-multipart
Nov 1, 2024
Merged

Move utility functions from _utils.py to _multipart.py#3388
lovelydinosaur merged 1 commit intoencode:masterfrom
RafaelWO:change/move-utils-to-multipart

Conversation

@RafaelWO
Copy link
Copy Markdown
Contributor

@RafaelWO RafaelWO commented Nov 1, 2024

Summary

Related issue: #3381

This PR moves the following utility functions from _utils.py to _multipart.py that are only used in _multipart.py

  • format_form_param
  • guess_content_type

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

The following functions are moved because they are only used in _multipart.py
* format_form_param
* guess_content_type
Copy link
Copy Markdown
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RafaelWO 😎

@lovelydinosaur lovelydinosaur merged commit 6212e8f into encode:master Nov 1, 2024
@RafaelWO RafaelWO deleted the change/move-utils-to-multipart branch November 1, 2024 14:29
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants