fix: set default elapsed on MockTransport responses#3719
Closed
SamMorrowDrums wants to merge 1 commit intoencode:masterfrom
Closed
fix: set default elapsed on MockTransport responses#3719SamMorrowDrums wants to merge 1 commit intoencode:masterfrom
SamMorrowDrums wants to merge 1 commit intoencode:masterfrom
Conversation
When creating a Response with pre-loaded content (e.g., json=...),
the BoundSyncStream is never consumed, so elapsed is never set.
This causes a RuntimeError when accessing response.elapsed.
This fix sets a default elapsed of timedelta(0) if not already set,
allowing users to access response.elapsed without errors while still
preserving any user-set elapsed values.
Fixes #3712
Author
|
The CI failure appears to be an unrelated flaky network test ( Test summary: 1 failed, 1416 passed, 1 skipped This is not related to the MockTransport changes in this PR. |
Contributor
|
I'll close this for now until we have a good design decision around it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #3712 by setting a default
elapsedvalue oftimedelta(0)on responses returned fromMockTransport.Problem
When creating a
Responsewith pre-loaded content (e.g.,json=...,content=...,text=...), the content is immediately read into_contentin the Response's__init__. Later, when the client wraps the response stream withBoundSyncStream/BoundAsyncStreamto track elapsed time, the stream is never actually consumed because_contentis already set.This causes a
RuntimeErrorwhen accessingresponse.elapsed:Solution
Set
elapsed = timedelta(0)as a default inMockTransport.handle_request()andhandle_async_request()if the response doesn't already have_elapsedset.This:
response.elapsedwithout errorsChanges
import datetimetohttpx/_transports/mock.pyhandle_request()(sync)handle_async_request()(async)Testing
Verified that:
response.elapsedreturnstimedelta(0)for pre-loaded responses