Conversation
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
Really cool we're adding this, it confused the heck out of me every time 😄
Left some questions and nitpicks on phrasing.
|
@yeraydiazdiaz I pushed some commits addressing your comments, feel free to give this another look. 😄 |
lovelydinosaur
left a comment
There was a problem hiding this comment.
I really think it's just the client certificates that come under the "you probably don't need this" disclaimer category.
|
@tomchristie Yeah, makes sense. I figured we could just drop the warning — after all, the whole page is labelled "Advanced Usage", right? 😄 |
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
LGTM thanks @florimondmanca
|
Mental note that it seems @sethmlarson might have trustme-cli brought into trustme directly (see sethmlarson/trustme-cli#1), so we’ll want to update the link here when that happens. :) |
Fixes #507