Skip to content

Version 0.13.8#1026

Merged
erewok merged 4 commits intomasterfrom
version-0.13.8
Aug 14, 2020
Merged

Version 0.13.8#1026
erewok merged 4 commits intomasterfrom
version-0.13.8

Conversation

@erewok
Copy link
Contributor

@erewok erewok commented Aug 11, 2020

  • Revert Queue maxsize fix in BaseHTTPMiddleware.
  • Staticfiles constructor now allows pathlib.Path (in addition to str) for directory keyword arg.

erewok added 2 commits August 10, 2020 18:50
Revert Queue maxsize fix in BaseHTTPMiddleware
@JayH5
Copy link
Contributor

JayH5 commented Aug 11, 2020

IMO the change to maxsize of the queue should be a separate PR or at least have an issue about the problem. I understand this was discussed in gitter, but that doesn't provide a good record of why changes were made, especially without a link to that discussion. I'd rather have the changelog link to that issue than trying to explain the problem fully in the changelog.

@erewok
Copy link
Contributor Author

erewok commented Aug 11, 2020

You're right @JayH5. Further, a separate PR for that change would give others more of a chance to comment on it as well. People are unlikely to see it here. Here's a PR with only that change: #1028

@erewok erewok marked this pull request as draft August 11, 2020 19:55
@erewok erewok marked this pull request as ready for review August 13, 2020 12:50
@erewok
Copy link
Contributor Author

erewok commented Aug 13, 2020

This PR has been updated to include only release notes and version bump.

@erewok erewok merged commit 31ad4e5 into master Aug 14, 2020
@erewok erewok deleted the version-0.13.8 branch August 14, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants