Use bytearray for field accumulation in FormParser#3179
Merged
Conversation
Replace immutable `bytes` concatenation with mutable `bytearray.extend()` in `FormParser.parse()` to avoid O(n²) copying when accumulating field names and values.
Kludex
force-pushed
the
use-bytearray-in-form-parser
branch
from
c95b041 to
57242ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytesconcatenation (+=) with mutablebytearray.extend()inFormParser.parse()to avoid O(n²) copying when accumulating field names and values.bytearray.decode()produces the samestrasbytes.decode().