Only dispatch standard HTTP verbs in HTTPEndpoint#3286
Merged
Conversation
HTTPEndpoint.dispatch() resolved the handler by looking up the lowercased request method as an attribute. Restrict dispatch to the canonical HTTP verb set, returning a 405 for anything else.
Kludex
changed the title
HTTPEndpoint
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPEndpoint.dispatch()resolved the request handler by looking up the lowercased request method as an attribute viagetattr(). This means the method name selects which instance attribute is called, with no restriction to actual HTTP verbs.This narrows dispatch to the canonical verb set (
GET,HEAD,POST,PUT,PATCH,DELETE,OPTIONS) - the same set already used to compute_allowed_methodsand theAllowheader. Any other method now returns405 Method Not Allowed, consistent with how unsupported standard verbs are already handled. TheHEAD->GETfallback is preserved.Test
Added a regression test covering a non-standard method, verified to fail before the change and pass after.
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.