Reject absolute paths in StaticFiles.lookup_path#3287
Merged
Conversation
Kludex
changed the title
StaticFiles.lookup_path
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StaticFiles.lookup_path()joins the requested path onto the served directory before resolving it. Because an absolute path makesos.path.joindiscard the directory it is joined onto, an absolute request path bypasses the directory it is supposed to be confined to.This rejects absolute paths up front (anything starting with
/or\), returning a not-found result before any filesystem resolution. Relative paths are unaffected.Test
Added tests covering POSIX absolute paths and backslash-prefixed paths.
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.