Merged
Conversation
Encord Agents test report83 tests 82 ✅ 3m 25s ⏱️ Results for commit 1d6918a. ♻️ This comment has been updated with latest results. |
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
9f8fcfb to
8008a55
Compare
frederik-encord
suggested changes
Mar 11, 2025
Jim-Encord
force-pushed
the
jb/fetch-storage-items-batched
branch
from
056f446 to
84a779a
Compare
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
2 times, most recently
from
ccc1b82 to
1eb60f0
Compare
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
1eb60f0 to
dcb7192
Compare
frederik-encord
suggested changes
Mar 13, 2025
Jim-Encord
force-pushed
the
jb/fetch-storage-items-batched
branch
from
3d4e0ae to
76c5d3e
Compare
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
dcb7192 to
1bd70bc
Compare
Jim-Encord
force-pushed
the
jb/fetch-storage-items-batched
branch
from
76c5d3e to
ce2e388
Compare
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
1bd70bc to
ea49116
Compare
Jim-Encord
force-pushed
the
jb/fetch-storage-items-batched
branch
from
ce2e388 to
4318c29
Compare
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
ea49116 to
a3c6cf2
Compare
frederik-encord
suggested changes
Mar 19, 2025
|
|
||
| ``` | ||
|
|
||
| We make use of the [bundle method](https://docs.encord.com/sdk-documentation/general-sdk/sdk-bulk-action-best-practices){target="_blank", rel="noopener"} |
Contributor
Author
There was a problem hiding this comment.
Added some more verbiage but debatable honestly the necessity of the sentence
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
3 times, most recently
from
f69f1c1 to
80191fe
Compare
frederik-encord
approved these changes
Mar 21, 2025
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
80191fe to
6a64589
Compare
Jim-Encord
commented
Mar 24, 2025
| assert AGENT_TO_COMPLETE_PATHWAY_HASH in str(e) | ||
|
|
||
|
|
||
| def test_queue_runner_return_struct_object(ephemeral_image_project_hash: str) -> None: |
Contributor
Author
There was a problem hiding this comment.
Note: This test is insanely slow as the current behaviour is that we can't really batch saving of label rows from a queue. Either migrate to the normal project and then we can't mutate the label row in a style agnostic way (AUDIO and PLAIN_TEXT don't allow adding object_instances like the current method).
Or maybe call with a max_task_size.
Looks like we could just move DecoratedCallable up rather than bring everything else down. Makes things slightly cleaner if we're not really providing this behaviour for editor agents
…g the label rows appropriately
Jim-Encord
force-pushed
the
jb/mark-items-as-updated
branch
from
6a64589 to
1d6918a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet fully implemented for the queue runner as passing hydrated objects is somewhat unclear.
But this covers batching of label updates to the Label objects and includes a pretty hefty test.