Expose SDL_Gamepad* handle via PAD API#68
Merged
Conversation
Will be using this in Dusk for input mapping etc
PJB3005
added a commit
to TwilitRealm/dusklight
that referenced
this pull request
Mar 27, 2026
Collaborator
|
I don't think this is a good idea, if you need more mapping functionality please create new PAD APIs, don't expose the underlying handle. |
Owner
|
I looked over the associated PR and it's fine. We could probably expose Yes, we should be careful to limit how much we rely on the underlying handles, and add Aurora APIs where it makes sense to, but we should not strive to reinvent the SDL API surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be using this in Dusk for input mapping etc