Strip trailing int3 instructions (alignment padding) for x64#354
Merged
Conversation
HaydnTrigg
force-pushed
the
x86_x64_int3_comparison
branch
2 times, most recently
from
54adbe6 to
d99656d
Compare
encounter
reviewed
Jun 1, 2026
| } | ||
| // Strip trailing int3 instructions (alignment padding) for x64 | ||
| if matches!(self.arch, Architecture::X86_64) { | ||
| while out.last().map(|i| i.opcode == iced_x86::Mnemonic::Int3 as u16).unwrap_or(false) { |
Owner
There was a problem hiding this comment.
tiny nit: .map_or is slightly nicer
Contributor
Author
There was a problem hiding this comment.
Fixed up. Then clippy had other plans and wants to use is_some_and
HaydnTrigg
force-pushed
the
x86_x64_int3_comparison
branch
from
d99656d to
05c1d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to do some comparison against objects compiled for x64 code with VS2012 17.0.65501.17028
The functions have unreliable sizes due to padding where a function may be 3 bytes large, but after adding a second function it will pad out to 16 byte alignment. However the newly added function is still only 1 byte aligned. This change removes trailing
int3instructions for comparison which are used to pad x64.Before matching %
Problem instructions
After %
